fix(a11y): use a more helpful text for the element drawings #194
+35
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The element page uses the description of the element as the text of the drawing, and the cards of the results list use an empty text, because the description is in the card just above the drawing. The rule is written in docs/ACCESSIBILITY.md. Closes #173
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
From the peer feedback (#167): "Illustration for 1.00" says little to a screen reader user, and the descriptions are already good.
There are only two places with a drawing, and both have the description right next to it, so one rule is used:
ElementDiagram.tsx): the text is the description of the element ("Clear hip circle to hstd"), because the drawing is the main content. If an element has no description it falls back to "Drawing of".ResultsTable.tsx): the text is empty (alt=""), because the description is in the card just above the drawing, and repeating it for 20 cards would be noise.The rule is written in
docs/ACCESSIBILITY.md, and there is a short entry indocs/AI_USAGE.md.Checked
imgrole (an image with an empty text has none). 427 frontend tests pass;tsc, ESLint and Prettier are clean.Closes #173
🤖 Generated with Claude Code